Repository navigation
feat: sample the on-screen picture with VideoSampleTap - #62
Merged
Merged
Conversation
PlayerSession.videoSamples hands the host the frame the renderer last displayed, so Lume can sample it for Philips Hue light sync. The tap is lazy and costs nothing until a host attaches it. Adds quadrant fixtures (8-bit H.264 and 10-bit HEVC) that pin the colour conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
VideoSampleTap, exposed asPlayerSession.videoSamples, so a host can drive something from what is on screen. Lume uses it for Philips Hue light sync on tvOS (bilipp/Lume#374, which needs this merged first).Implementation
sample(atOrBefore: currentTime), since frames are enqueued ahead of the clock.quadrant.mp4(8-bit H.264) andquadrant10.mp4(10-bit HEVC) ingenerate-fixtures.sh.Note: the commit message says the tap hands over the last displayed frame; it actually samples a colour grid as described above. Worth fixing in the squash message.
Testing
FrameSampleTapTests(new) against both quadrant fixtures.