Repository navigation
fix(extension): speed up text locator count and nth on large lists - #3308
Open
ShivanshSinghaL06 wants to merge 1 commit into
Open
ShivanshSinghaL06 wants to merge 1 commit into
ShivanshSinghaL06 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f4f1ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run. |
github-actions
Bot
added
external-contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
text=locatorcount()andnth()take seconds on large repeated lists: text matching removes ancestor matches with a pairwisecontainsloop, and indexed resolution re-scans the page once per index and keeps a remote handle for every preceding match.Closes #3238
what changed
textMatches.ts) used by bothcountTextMatchesandresolveTextSelector. Ancestors are suppressed during the walk and leaves skip layout when their text has no whitespace to collapse.nthstops early once the requested index is found.FrameSelectorResolver.resolveAtIndexnow evaluates the selector helper once and creates one remote object, instead of going throughresolveAll.test plan
textSelectorInnermost,locatorNth,locatorCount): 26 of 26 pass in Edge on Windows.count()~4,124 ms to ~15 ms,nth(2).innerText()~12,498 ms to ~15 ms. The first call is ~1.25 s because of cold-start setup.Summary by cubic
Speeds up
text=locatorcount()andnth()on large repeated lists.containsloop, andnth()stops early after finding the requested index.FrameSelectorResolver.resolveAtIndexnow evaluates the selector helper once and returns one remote object, instead of resolving and releasing all preceding matches.Written for commit f4f1ba4. Summary will update on new commits.