Repository navigation
Fix smart double quote closing before adjacent text - #89
Conversation
delucis
left a comment
There was a problem hiding this comment.
Question: what happens for the inverse case where the " follows some CJK text? For example:
표지판에"About me"라고 적혀 있는 것 같아요.
Good call 🧠 I was so focused on fixing the issue the visual diff checker found, I didn't even think of that 🙌 |
|
Does the same thing happens to single quotes? It's less likely to happens in natural text, I assume, but if it's the same problem we could probably fix both |
It probably does but I intentionally avoided it for this PR as the same character can be used for quoted text and apostrophes. For example, Altho if you want, I can investigate it and see if it could be added to this PR rather than a future one. |
|
I think it's fine, if it ever comes up with single quotes we can fix it then :) |
Description
This PR fixes a smart punctuation issue and ensure a trailing double quote is rendered as a closing quote when text follows the quoted text without whitespace.
For example, considering the sentence
"About Me"로, before this PR, the output would be“About Me“로instead of“About Me”로.Note that I'm not quite sure I selected all the proper packages when running
pnpx sampo add. Please let me know if I missed any or some may not be relevant to this change.