Repository navigation
Versioned dependencies (via --dep) are not found #136
Description
I have the following WAC document:
package root:component-val@0.0.1 targets fermyon:spin/http-trigger@2.0.0;
let c = new root:component { ... };
export c...;
I resolve it like so:
wac resolve aaugh.wac --registry wa.dev --dep "root:component=./target/wasm32-wasi/release/calculator_spin.wasm"
And life is good. But if I change root:component to have a version:
package root:component-val@0.0.1 targets fermyon:spin/http-trigger@2.0.0;
let c = new root:component@0.0.1 { ... };
export c...;
and invoke with the version:
wac resolve aaugh.wac --registry wa.dev --dep "root:component@0.0.1=./target/wasm32-wasi/release/calculator_spin.wasm"
I get:
error: failed to resolve document
× package `root:component` does not exist in the registry
╭─[aaugh.wac:3:13]
2 │
3 │ let c = new root:component@0.0.1 { ... };
· ──────────┬─────────
· ╰── package `root:component` does not exist
4 │
╰────
(If I revert the command line to the unversioned, uh, version, same error.)
Is this behaviour intentional? If so, could the error indicate more specifically what the user should do to fix it?
Activity
calvinrp commentedon Jul 30, 2024
This might be the relevant line that needs to be revised: https://github.com/bytecodealliance/wac/blob/main/crates/wac-resolver/src/fs.rs#L37
Some(path) if key.version.is_none() => {might need to drop the conditional requirement that version not being specified in order to use theoverridesfile path.@itowlson let me know if that fixes
itowlson commentedon Jul 30, 2024
@calvinrp Thanks for looking into that. The fix you suggest worked for me (in my one test case!). I haven't explored if it impacts anything else though - @peterhuene do you recall why you specified that condition?
calvinrp commentedon Jul 30, 2024
A PR could add additional test cases and document the expected usage patterns. Seems safe to do.