Repository navigation
Open
Description
I'm trying to wrap a component that implments wasi:http/incoming-handler into a different api. The way I'm trying to accomplish this is by having two different components that will be composed with it.
- Exports the wasi:http/types interface + some extensions. This will be composed with (2) and (3) and has otherwise no imports (except other wasi interfaces)
- The wrapped component. This imports wasi:http/types and exports wasi:http/incoming-handler.
- A component providing the new api. This imports wasi:http/types, wasi:http/incoming-handler, the extensions from (1) and exports the new api.
Problem is that when I try composing the wasm, it errors with:
❯ wac plug adapter.wasm --plug types.wasm -o adapter-plugged.wasm
error: encoding produced a component that failed validation
Caused by:
type mismatch for import `wasi:http/incoming-handler@0.2.3`
type mismatch in instance export `incoming-request`
resource types are not the same (ResourceId { globally_unique_id: 2, contextually_unique_id: 8 } vs. ResourceId { globally_unique_id: 2, contextually_unique_id: 57 }) (at offset 0x4e0399)
This error shows up both for wac plug and wac compose.
Wits look as follows:
Component 1:
package poc:types;
interface extensions {
use wasi:http/types@0.2.3.{method, scheme, status-code, incoming-request, response-outparam};
type fields = list<tuple<string, list<u8>>>;
type body = list<u8>;
record body-and-trailers {
body: body,
trailers: option<fields>
}
record request {
method: method,
path-with-query: string,
scheme: scheme,
authority: string,
headers: fields,
body-and-trailers: option<body-and-trailers>
}
record response {
status: status-code,
body: option<body-and-trailers>
}
resource response-outparam-proxy {
constructor();
new-outparam: func() -> response-outparam;
get-response: func() -> response;
}
new-wasi-http-request: func(request: request) -> incoming-request;
}
world api {
export wasi:http/types@0.2.3;
export extensions
}
Component 2:
package poc:handler;
world api {
import wasi:http/types@0.2.3;
export wasi:http/incoming-handler@0.2.3;
}
Component 3:
package poc:adapter;
interface adapted-api {
use poc:types/extensions.{request, response};
handle: func(request: request) -> response;
}
world api {
import wasi:http/incoming-handler@0.2.3;
import wasi:http/types@0.2.3;
import poc:types/extensions;
export adapted-api;
}
I suspect this is a similiar error to bytecodealliance/wasm-tools#1565. This comment provided a reproduction that fails with the same error.
Metadata
Metadata
Assignees
Labels
No labels
Activity
vigoo commentedon Jan 28, 2025
I now have a much smaller reproducer for this, still investigating the root cause. Just wanted to add some details from this ongoing investigation, in case it triggers some ideas
The following simple case produces the composition error:
"socket" component:
"plug" component:
Trying to "plug" this wrapper to the other component produces a component with the following validation error:
The following is also true:
monotonic-clock, which is imported into the inner component, is referring toPollableinwasi:io/poll.wasi:io/poll, works (for example I can importwasi:logging/logginginto the inner component with no problem)monotonic-clock, the composition succeedselewis787 commentedon Apr 17, 2025
@jeff1010322 and I are also running into this error.
We have created a repository that highlights the reproducible issue at https://github.com/hayride-dev/compose-bug.
In the example, we create 3 components
We build foo, foo-bar, and foo-bar-baz as components, then use WAC to compose them together.
wac plug foo-bar.wasm --plug foo.wasm -o foo-bar-composed.wasmwac plug foo-bar-baz.wasm --plug foo-bar-composed.wasm -o foo-bar-baz-composed.wasmIn the above example, foo-bar and foo are successfully plugged.
However, when attempting to plug
foo-bar-composed.wasmwith foo-bar-baz.wasm, the following error is triggeredThis can also be triggered by attempting to plug
foo.wasmdirectly into foo-bar-baz.wasmBased on code comments in https://github.com/bytecodealliance/wasm-tools/blob/351f1537490f7d5e4a61f8ab16302984589d25d2/crates/wasmparser/src/validator/component_types.rs#L1284 and the error message, we suspect that this is related to the
contextually_unique_ideach component is generating for the resource that is attempting to be passed between components.Any suggestions on a workaround would be awesome, or guidance on the root cause.