Skip to content

Provide option to downgrade unknown import errors to warnings #56

Open

Description

@salmans

When instantiating a component, it's probably safe to supply it with additional imports that aren't declared in its world. For example, consider a component that declares an import foo in its world but it doesn't use foo in its implementation. Consequently, foo won't be present in the component's WIT that is generated by witgen, which will cause a confusing unknown import error by wac. I think downgrading the error to a warning would be enough to let the user know about a potential logical error while allowing wac to run successfully.

Activity

  1. rylev commented on Mar 22, 2024

    @rylev
    Collaborator

    I'm also running into this issue. For languages with good dead code elimination like Rust the resulting component binary might not reflect the exact targeted world if the any imports are not used - those imports will simply be removed. It would be nice if supply imports that don't exist was simply a warning as supplying an import that doesn't exist is essentially a noop.

    Of course, this will largely go away with a programatic API where the actual world of the component can be dynamically inspected and only imports it actually requires can be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions