miette #347 has been merged, fixing #219

Maybe this comment can be addressed now?

Lines 466 to 479 in d3f6be2

    
               pub fn span(&self) -> SourceSpan { 
        
                   let mut span = self.0.span(); 
        
                   if span.end == self.0.source().len() { 
        
                       // Currently miette silently fails to display a label 
        
                       // if the span is at the end of the source; this means 
        
                       // we can't properly show the "end of input" span. 
        
                       // For now, have the span point at the last byte in the source. 
        
                       // See: https://github.com/zkat/miette/issues/219 
        
                       span.start -= 1; 
        
                       span.end = span.start + 1; 
        
                   } 
        
                   to_source_span(span) 
        
               }

Thanks for the suggestion!

I think the miette fix will now at least not be silent when the span is invalid, but that's not how we want it to behave for being able to convey an unexpected end-of-input (i.e. show highlight one past the last valid offset).

I'll test it out, but we'd probably need a feature request from miette if we want it to happen.

Thanks for taking a look. I hoped you would know if the special case could be removed straight away or if there were now something new to consider. I know your plate is full right now. I can't say I have even run your wac binary yet so can't offer help yet. Still getting my head around all the new stuff since WASI Preview 2 and the tooling the BA is providing.

Navigation Menu

Repository navigation

miette #347 has been merged, fixing #219 #77

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	pub fn span(&self) -> SourceSpan {
	let mut span = self.0.span();
	if span.end == self.0.source().len() {
	// Currently miette silently fails to display a label
	// if the span is at the end of the source; this means
	// we can't properly show the "end of input" span.
	// For now, have the span point at the last byte in the source.
	// See: https://github.com/zkat/miette/issues/219
	span.start -= 1;
	span.end = span.start + 1;
	}

	to_source_span(span)
	}

miette #347 has been merged, fixing #219 #77

Description

Activity

peterhuene commented on Apr 12, 2024

FrankReh commented on Apr 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions