Repository navigation
Enable all Wasm features in Validator - #146
Merged
Merged
Conversation
fix bytecodealliance#145 Enable all Wasm features in the `Validator` so we can use components that rely on Wasm features that isn't enabled by default, such as `gc`.
tanishiking
force-pushed
the
enable-all-features
branch
from
January 6, 2025 12:36
5309517 to
588bfb2
Compare
calvinrp
self-requested a review
January 6, 2025 15:14
calvinrp
approved these changes
Jan 6, 2025
Collaborator
|
Thanks for the PR. Yeah, seems reasonable for Wac to have all the features enabled by default for validation purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #145
Enable all Wasm features in the
Validatorso we can use components that rely on Wasm features that isn't enabled by default, such asgc.This PR enabled all the Wasm features (a workaround (2) in #145), but if we want to support command line arguments something like
--featuresinstead, let me know :)( personally think it's reasonable that
wacto support all features by default though)