isDaytime and isNightTime return incorrect values for polar day #59

Activity

1. daneden commented on Jun 26, 2024

   

   daneden

   on Jun 26, 2024

   More actions

   I know this is an old bug, but I’ve been using Solar extensively for my project Solstice and polar days/nights are so tricky! I’ve figured out a workaround that involves checking whether the coordinates are within a polar circle:

   import CoreLocation
   import Solar
   
   extension CLLocationCoordinate2D {
     var insideArcticCircle: Bool { latitude > 66.34 }
     var insideAntarcticCircle: Bool { latitude < -66.34 }
     var insidePolarCircle: Bool { insideArcticCircle || insideAntarcticCircle }
   }
   
   extension Solar {
     var isSunUp: Bool {
       if sunrise != nil && sunset != nil {
         return isDaytime
       }
   
       guard coordinate.insidePolarCircle else { return isDaytime }
   
       let month = Calendar.current.component(.month, from: date)
   		
       switch month {
         case 1...3, 10…12:
           return coordinate.insideAntarcticCircle
         default:
           return coordinate.insideArcticCircle
       } 
     }
   }

   This works by:

   1. Returning isDaytime if there is a sunrise/sunset (which is how isDaytime works under the hood anyway)
   2. Checking whether the coordinates lie within a polar circle, and returning isDaytime if they don't
   3. Returning a boolean based on:
      a. Which polar circle the coordinates are in
      b. Whether the date lies within the northern hemisphere’s winter months

   👍React with 👍2Reacted by Gerry Shaw and Eugene Kovs
2. ceeK

   added 3 commits that reference this issue on Aug 31, 2026

   fix: isDaytime wrong during polar day (#59)

   ...

   6a0a7c3

   fix: isDaytime wrong during polar day (#59)

   ...

   b2a4a16

   fix: isDaytime wrong during polar day (#59)

   ...

   ee2924a