Skip to content
This repository was archived by the owner on Oct 11, 2019. It is now read-only.
This repository was archived by the owner on Oct 11, 2019. It is now read-only.

design review #51

Open
Open

Description

@dgreisen-cfpb

Several things wanted to check with you on:

  • result list - including need better distinguishing between title/content
  • highlighting
  • more button at bottom
  • any other issues with layout/style/positioning

Will probably be back with a couple more once we have autocomplete implemented.

Activity

  1. mebates commented on Mar 26, 2014

    @mebates

    Hey David, here are my suggestions:

    • Pull the article name up to the same line as the path. Make both our H4 style, 18/22 px Avenir Medium.
    • Make content Georgia Web Body, 16/22 px
    • Make highlights Gold 80 instead of full Gold
    • Make 'more' say 'More results...' in Avenir Web Body underlined with CFPB's dotted link style
    • Move the magnifying glass icon to the left of the box, like on the Intranet.
    • Shrink size of search in box to H2: 26 px
    • Search box seems very, very wide. Should you shink and center it?
    • What purpose does the book icon serve, if they're all book icons? Perhaps you should cut them.
    • The page is very wide on my laptop. Your search results don't extend to the edge, why not make it a bit narrower?
  2. himedlooff commented on Jul 3, 2014

    @himedlooff
    Contributor

    @mebates now that autocomplete is being added here is how things look when the search icon is moved to the left. Notice how I added some left padding to align the autocomplete results with the search box text. Do you think that's good?

    screen shot 2014-07-03 at 5 05 24 pm

    Or should we just leave the padding alone like this:

    screen shot 2014-07-03 at 5 07 09 pm

  3. himedlooff commented on Jul 3, 2014

    @himedlooff
    Contributor

    Or I could move the drop down over from the left.

    screen shot 2014-07-03 at 5 17 29 pm

    Looks kind of weird...

  4. mebates commented on Jul 7, 2014

    @mebates

    Hey @himedlooff : I prefer your first attempt, with the extra padding on the left to align under what you're typing.

  5. himedlooff commented on Jul 8, 2014

    @himedlooff
    Contributor

    Thanks @mebates, pull request #60 should make that happen.

  6. himedlooff commented on Jul 8, 2014

    @himedlooff
    Contributor

    I think I addressed all of your recommendations:

    screen shot 2014-07-08 at 10 32 17 am

  7. himedlooff commented on Oct 22, 2015

    @himedlooff
    Contributor

    Can we close this, or remove me from assigned? =D

  8. removed their assignment
    on Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions