Repository navigation
Conversation
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Cartesian line or scatter chart throws during creation with
fill: {target: 'shape', above: 'red', below: 'blue'}. Shape mode resolves its target totrue, but the differing-color path tries to clip against that target'ssegmentsas if it were a line.Change
Skip boundary-color clipping for the shape sentinel. Shape mode has no target boundary to compare against. It keeps the existing single-color behavior using
below, including the fallback to the dataset background color, rather than adding a new two-color shape interpretation.Actual line targets and scale boundaries still use the existing above/below clipping.
Verification
pnpm build, including declaration generation, andtsc --noEmit: pass.Firefox and downstream integration suites were not run.