Skip to content

fix: bump version to 1.1.1 - #334

Open
raj-gh-altana wants to merge 1 commit into
chmln:masterfrom
raj-gh-altana:fix/bump-version-1.1.0
Open

fix: bump version to 1.1.1#334
raj-gh-altana wants to merge 1 commit into
chmln:masterfrom
raj-gh-altana:fix/bump-version-1.1.0

Conversation

@raj-gh-altana

@raj-gh-altana raj-gh-altana commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • sd --version was incorrectly reporting 1.0.0 instead of 1.1.1
  • Updates version in Cargo.toml (workspace), Cargo.lock, and the man page (gen/sd.1)

Test plan

  • cargo run --bin sd -- --version reports sd 1.1.1

🤖 Generated with Claude Code

Raj Shah @claude
fix: bump version to 1.1.1
18205d1 
`sd --version` was incorrectly reporting 1.0.0. Update the version
in Cargo.toml (workspace), Cargo.lock, and the man page.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@raj-gh-altana
raj-gh-altana force-pushed the fix/bump-version-1.1.0 branch from 679ae63 to 18205d1 Compare March 5, 2026 05:27
@raj-gh-altana raj-gh-altana changed the title fix: bump version to 1.1.0 fix: bump version to 1.1.1 Mar 5, 2026
@raj-gh-altana

raj-gh-altana commented Mar 5, 2026

Copy link
Copy Markdown
Author

fixes #332

@raj-gh-altana

raj-gh-altana commented Mar 5, 2026

Copy link
Copy Markdown
Author

@oriongonza Can this be merged and fixed and released ASAP? Not being able to check the version properly make dealing with the breaking changes released in 1.1.0 with the -A flag difficult

@ilovemikael

ilovemikael commented May 8, 2026

Copy link
Copy Markdown

why hasn't this been merged?

@antoniocali

antoniocali commented May 14, 2026

Copy link
Copy Markdown

please update accordingly since it's indeed a problem

@sunrisever

sunrisever commented Jul 31, 2026

Copy link
Copy Markdown

Confirmed that this also affects the official Homebrew macOS arm64 bottle:

  • Homebrew formula and linked keg: sd 1.1.0
  • Installed binary: /opt/homebrew/Cellar/sd/1.1.0/bin/sd
  • Actual output: sd --version -> sd 1.0.0
  • The v1.1.0 tag still has [workspace.package] version = "1.0.0"

Bumping the workspace, lockfile, and generated man page to 1.1.1 is the correct fix without rewriting the published v1.1.0 tag. A new v1.1.1 release will still be needed for Homebrew and other package managers to pick up the corrected metadata.

ak2
ak2 reviewed Oct 3, 2026
View reviewed changes
Comment thread Cargo.toml
[workspace.package]
edition = "2024"
version = "1.0.0"
version = "1.1.1"

@ak2 ak2 Oct 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be 2.0.0 due to disabling multiline matching by default, which does make sense, but breaks scripts that rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ak2 ak2 ak2 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raj-gh-altana @ilovemikael @antoniocali @sunrisever @ak2