Skip to content

fix(io): flush manually in poll_close - #681

Merged
Berrysoft merged 3 commits into
compio-rs:masterfrom
Berrysoft:fix/io-async-close
Feb 13, 2026
Merged

Berrysoft merged 3 commits into
compio-rs:masterfrom
Berrysoft:fix/io-async-close

Conversation

@Berrysoft

Copy link
Copy Markdown
Member

Closes #673

@Berrysoft Berrysoft self-assigned this Feb 12, 2026
@Berrysoft Berrysoft added bug Something isn't working package: io Related to compio-io labels Feb 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread compio-io/src/compat/async_stream.rs Resolved
Comment thread compio-io/src/compat/async_stream.rs Resolved
George-Miao
George-Miao previously approved these changes Feb 12, 2026

@George-Miao George-Miao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao

Copy link
Copy Markdown
Member

Actually, can you add a testcase that reproduces #673?

@Berrysoft

Copy link
Copy Markdown
Member Author

I'll add one later.

@George-Miao George-Miao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao

Copy link
Copy Markdown
Member

Donno why illumos is randomly failing on that timeout test...

@Berrysoft

Copy link
Copy Markdown
Member Author

I'll try to debug it later.

@Berrysoft
Berrysoft merged commit 11785e5 into compio-rs:master Feb 13, 2026
55 of 62 checks passed
@Berrysoft
Berrysoft deleted the fix/io-async-close branch February 13, 2026 03:16
Berrysoft added a commit that referenced this pull request Feb 13, 2026
* fix(io): flush manually in poll_close

* fix(io): avoid deadlock

* test(io): close
@github-actions github-actions Bot mentioned this pull request Feb 12, 2026
This was referenced Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: io Related to compio-io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS connections always get unexpected eof when the server closes the connection

3 participants