Skip to content

feat(runtime)!: remove event - #707

Merged
George-Miao merged 4 commits into
compio-rs:masterfrom
Berrysoft:remove-event
Feb 24, 2026
Merged

George-Miao merged 4 commits into
compio-rs:masterfrom
Berrysoft:remove-event

Conversation

@Berrysoft

@Berrysoft Berrysoft commented Feb 24, 2026 •

Copy link
Copy Markdown
Member

Closes #696

George-Miao
George-Miao previously approved these changes Feb 24, 2026

@George-Miao George-Miao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the event API surface from compio-runtime and migrates internal consumers to synchrony’s async-flag primitives, simplifying feature wiring across the workspace.

Changes:

  • Remove compio-runtime::event module and related event feature/re-exports.
  • Update Windows resolver and signal handling to use synchrony::{AsyncFlag, AsyncFlagHandle}.
  • Adjust workspace/crate Cargo.toml dependencies and test requirements accordingly.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
compio/src/lib.rs Drops runtime::event re-export.
compio/Cargo.toml Removes event feature and updates signal feature dependencies.
compio-signal/src/windows.rs Switches from compio_runtime::event to synchrony async-flag.
compio-signal/src/unix.rs Switches from compio_runtime::event to synchrony async-flag (non-Linux Unix path).
compio-signal/Cargo.toml Removes compio-runtime “event” dependency; adds synchrony (non-Linux) and adjusts target deps.
compio-runtime/tests/event.rs Removes tests for the deleted Event API; keeps Windows IOCP event test.
compio-runtime/tests/custom_loop.rs Replaces compio_runtime::event usage with synchrony async-flag.
compio-runtime/src/lib.rs Removes pub mod event.
compio-runtime/src/event.rs Deletes the old Event/EventHandle implementation.
compio-runtime/Cargo.toml Removes event feature and updates test required-features/dev-deps.
compio-net/src/resolve/windows.rs Replaces runtime Event/EventHandle with synchrony async-flag for async DNS resolution.
compio-net/Cargo.toml Drops compio-runtime event feature usage; adds synchrony on Windows.
Cargo.toml Bumps workspace synchrony version to 0.1.4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread compio/Cargo.toml Resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Berrysoft

Copy link
Copy Markdown
Member Author

Oh, have to fix the CI.

@George-Miao George-Miao changed the title feat(runtime): remove event feat(runtime)!: remove event Feb 24, 2026
@George-Miao George-Miao added breaking change package: runtime Related to compio-runtime labels Feb 24, 2026

@George-Miao George-Miao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao
George-Miao merged commit 6d5d254 into compio-rs:master Feb 24, 2026
54 checks passed
@github-actions github-actions Bot mentioned this pull request Feb 24, 2026
@Berrysoft
Berrysoft deleted the remove-event branch February 24, 2026 09:04
This was referenced Apr 21, 2026
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change package: runtime Related to compio-runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Remove mod event

3 participants