Repository navigation
feat(driver): make stub & iocp driver non-send and test - #728
Merged
Merged
Conversation
Berrysoft
approved these changes
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes assert_not_impl! in compio-driver and uses it to enforce that drivers (including stub and IOCP) and the Proactor are !Send/!Sync, with corresponding type-level markers.
Changes:
- Moved
assert_not_impl!macro fromcompio-runtimeintocompio-driverand updated call sites. - Made stub and IOCP drivers explicitly non-
Send/non-Syncvia marker fields and compile-time assertions. - Added compile-time
!Send/!Syncassertions forProactorandsys::Driver.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-runtime/src/runtime/time.rs | Switched TimerFuture !Send/!Sync assertions to the macro exported by compio-driver. |
| compio-runtime/src/lib.rs | Removed the local assert_not_impl! macro definition. |
| compio-driver/src/sys/stub/mod.rs | Added a marker field to prevent the stub Driver from being Send/Sync. |
| compio-driver/src/sys/mod.rs | Added compile-time assertions that Driver is !Send/!Sync. |
| compio-driver/src/sys/iocp/mod.rs | Added a marker field to prevent the IOCP Driver from being Send/Sync. |
| compio-driver/src/macros.rs | Added an exported (hidden) assert_not_impl! macro. |
| compio-driver/src/lib.rs | Added compile-time assertions that Proactor is !Send/!Sync. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.