Skip to content

fix: unused_features - #739

Merged
George-Miao merged 2 commits into
compio-rs:masterfrom
George-Miao:fix/unused-features
Mar 6, 2026
Merged

George-Miao merged 2 commits into
compio-rs:masterfrom
George-Miao:fix/unused-features

Conversation

@George-Miao

@George-Miao George-Miao commented Mar 6, 2026 •

Copy link
Copy Markdown
Member

Our CI exploded...

Copilot AI review requested due to automatic review settings March 6, 2026 06:55
@George-Miao George-Miao self-assigned this Mar 6, 2026
@George-Miao George-Miao added the bug Something isn't working label Mar 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI failures caused by the Rust unused_features lint being escalated to an error during cargo clippy --all-features --all-targets -- -Dwarnings, by suppressing that lint at the crate level across the workspace. It also refreshes the pinned Nix rust-overlay revision in flake.lock.

Changes:

  • Add #![allow(unused_features)] to multiple crates’ lib.rs to prevent unused_features warnings from failing clippy under -Dwarnings.
  • Update the Nix flake lock for oxalica/rust-overlay to a newer revision/hash.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
flake.lock Bumps the pinned rust-overlay lock entry (rev/hash/lastModified).
compio/src/lib.rs Allows unused_features at crate root to keep clippy -Dwarnings green under --all-features.
compio-ws/src/lib.rs Same lint allowance at crate root.
compio-tls/src/lib.rs Same lint allowance at crate root.
compio-signal/src/lib.rs Same lint allowance at crate root.
compio-runtime/src/lib.rs Same lint allowance at crate root.
compio-quic/src/lib.rs Same lint allowance at crate root.
compio-process/src/lib.rs Same lint allowance at crate root.
compio-net/src/lib.rs Same lint allowance at crate root.
compio-io/src/lib.rs Same lint allowance at crate root.
compio-fs/src/lib.rs Same lint allowance at crate root.
compio-driver/src/lib.rs Same lint allowance at crate root.
compio-dispatcher/src/lib.rs Same lint allowance at crate root.
compio-buf/src/lib.rs Same lint allowance at crate root.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Berrysoft Berrysoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to remove the unused feature?

@George-Miao

Copy link
Copy Markdown
Member Author

read_buf is actually used, on some platforms but not others. Manually filter those out will result in a huge blob of cfg's on top of crate...

@George-Miao
George-Miao merged commit cff7a25 into compio-rs:master Mar 6, 2026
21 of 63 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 6, 2026
This was referenced Apr 21, 2026
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants