Repository navigation
fix: unused_features - #739
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses CI failures caused by the Rust unused_features lint being escalated to an error during cargo clippy --all-features --all-targets -- -Dwarnings, by suppressing that lint at the crate level across the workspace. It also refreshes the pinned Nix rust-overlay revision in flake.lock.
Changes:
- Add
#![allow(unused_features)]to multiple crates’lib.rsto preventunused_featureswarnings from failing clippy under-Dwarnings. - Update the Nix flake lock for
oxalica/rust-overlayto a newer revision/hash.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| flake.lock | Bumps the pinned rust-overlay lock entry (rev/hash/lastModified). |
| compio/src/lib.rs | Allows unused_features at crate root to keep clippy -Dwarnings green under --all-features. |
| compio-ws/src/lib.rs | Same lint allowance at crate root. |
| compio-tls/src/lib.rs | Same lint allowance at crate root. |
| compio-signal/src/lib.rs | Same lint allowance at crate root. |
| compio-runtime/src/lib.rs | Same lint allowance at crate root. |
| compio-quic/src/lib.rs | Same lint allowance at crate root. |
| compio-process/src/lib.rs | Same lint allowance at crate root. |
| compio-net/src/lib.rs | Same lint allowance at crate root. |
| compio-io/src/lib.rs | Same lint allowance at crate root. |
| compio-fs/src/lib.rs | Same lint allowance at crate root. |
| compio-driver/src/lib.rs | Same lint allowance at crate root. |
| compio-dispatcher/src/lib.rs | Same lint allowance at crate root. |
| compio-buf/src/lib.rs | Same lint allowance at crate root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Berrysoft
approved these changes
Mar 6, 2026
Berrysoft
left a comment
Member
There was a problem hiding this comment.
Why not to remove the unused feature?
Member
Author
|
read_buf is actually used, on some platforms but not others. Manually filter those out will result in a huge blob of cfg's on top of crate... |
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI exploded...