Repository navigation
feat(driver,net,unix): async bind & listen - #806
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds async bind/listen support to the Unix driver layer and wires it through compio-net so socket setup/bind/listen can be performed via submitted driver ops (io-uring/poll backends) instead of direct syscalls.
Changes:
- Replace
Socket::bindconstructor usage withSocket::new+ asyncSocket::bind(...)across TCP/UDP/Unix listener codepaths. - Introduce new driver ops
BindandListenand implement them for polling + io-uring backends. - Re-export the new ops from
compio-driver::opfor Unix builds.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-net/src/unix.rs | Switch UnixListener setup to new + async bind/listen. |
| compio-net/src/udp.rs | Switch UDP bind path to new + async bind. |
| compio-net/src/tcp.rs | Switch TCP listen/connect bind steps to async bind/listen. |
| compio-net/src/socket.rs | Redefine bind/listen as async instance methods (Unix uses driver ops). |
| compio-driver/src/sys/unix_op.rs | Add Bind and Listen op structs. |
| compio-driver/src/sys/poll/op.rs | Implement OpCode for Bind/Listen in polling backend. |
| compio-driver/src/sys/iour/op.rs | Implement OpCode for Bind/Listen in io-uring backend. |
| compio-driver/src/op.rs | Re-export Bind and Listen for Unix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@George-Miao could you approve it again? I fixed some build errors. |
Berrysoft
added this pull request to the merge queue
Mar 28, 2026
Merged
via the queue into
compio-rs:master
with commit Mar 28, 2026
20f149a
120 of 121 checks passed
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.