Repository navigation
test(ws): handle messages gracefully - #812
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WebSocket test suite to avoid relying on explicit control-frame replies in test tasks and to validate the close handshake more explicitly, aligning behavior with tungstenite’s internal control-frame handling.
Changes:
- Simplify ping/pong server-side test logic by asserting receipt of
Pingrather than manually sendingPong. - Extend the close-handshake test to read and assert a close message after initiating
close()on the client side.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected by the sanitizer.