Repository navigation
feat(runtime)!: waker-based future combinator - #825
Merged
George-Miao merged 4 commits intoApr 2, 2026
Merged
Conversation
George-Miao
force-pushed
the
feat/runtime/waker-combinator
branch
from
April 2, 2026 00:09
6968f36 to
7ab9096
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make the runtime’s future combinators waker-based (instead of relying on Context extensions / nightly-only APIs), and removes the future-combinator feature gating so combinators are always available.
Changes:
- Removes the
future-combinatorfeature fromcompioandcompio-runtimeand enables combinator modules unconditionally. - Refactors combinators (
with_cancel,with_personality) to propagate data via a custom waker path (with_ext/ExtWaker). - Moves/removes the old
OptWakermodule wiring (intended to live under a newwakermodule).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| compio/Cargo.toml | Removes the future-combinator feature and its inclusion in nightly. |
| compio-runtime/Cargo.toml | Removes future-combinator feature and simplifies nightly feature list. |
| compio-runtime/src/lib.rs | Switches from opt_waker module to waker module and updates re-exports/docs. |
| compio-runtime/src/opt_waker.rs | Deletes the previous OptWaker implementation file. |
| compio-runtime/src/future/mod.rs | Makes future::combinator always compiled and re-exported. |
| compio-runtime/src/future/future.rs | Changes how cancel/extra are extracted (via waker extension instead of context extensions). |
| compio-runtime/src/future/combinator/mod.rs | Updates combinator extension storage (Ext) and adds/updates combinator docs. |
| compio-runtime/src/future/combinator/cancel.rs | Reworks with_cancel polling to use the new waker-based extension mechanism. |
| compio-runtime/src/future/combinator/personality.rs | Reworks with_personality polling to use the new waker-based extension mechanism. |
| compio-runtime/src/cancel.rs | Updates docs and removes feature-gated behavior from CancelToken::current(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
force-pushed
the
feat/runtime/waker-combinator
branch
11 times, most recently
from
April 2, 2026 02:27
f65b16a to
8344f23
Compare
Member
Author
|
To properly test for cancel result, I changed all ETIMEOUT back to ECANCELED and add an extension trait for |
George-Miao
force-pushed
the
feat/runtime/waker-combinator
branch
3 times, most recently
from
April 2, 2026 02:49
fc4950d to
9ef9748
Compare
George-Miao
enabled auto-merge
April 2, 2026 03:04
4 of 5 tasks
Berrysoft
reviewed
Apr 2, 2026
Berrysoft
reviewed
Apr 2, 2026
Berrysoft
requested changes
Apr 2, 2026
Berrysoft
left a comment
Member
There was a problem hiding this comment.
OK to test for IOCP later, but should remove socket2.
George-Miao
force-pushed
the
feat/runtime/waker-combinator
branch
from
April 2, 2026 16:36
9ef9748 to
f538506
Compare
George-Miao
force-pushed
the
feat/runtime/waker-combinator
branch
from
April 2, 2026 16:38
f538506 to
d2d13c8
Compare
Berrysoft
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING: Removed
future-combinatorfeature,ECANCELEDare returned as-is.