Skip to content

fix(runtime): remove generic for ext waker - #839

Merged
George-Miao merged 1 commit into
compio-rs:masterfrom
George-Miao:fix/runtime/ext-waker
Apr 6, 2026
Merged

George-Miao merged 1 commit into
compio-rs:masterfrom
George-Miao:fix/runtime/ext-waker

Conversation

@George-Miao

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 6, 2026 15:52
Berrysoft
Berrysoft previously approved these changes Apr 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the runtime’s “ext waker” plumbing by removing the generic ExtData abstraction and standardizing waker extension data handling around the crate’s Ext type.

Changes:

  • Removed the ExtData trait and updated ExtWaker/OwnedExtWaker to carry Ext directly (non-generic vtables and helpers).
  • Updated waker helper APIs (with_ext, get_waker, get_ext) to be non-generic and adjusted call sites accordingly.
  • Refactored future::Ext to provide an inherent to_owned() method (instead of implementing ExtData).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
compio-runtime/src/waker/ext.rs Removes generic ext-data handling and makes ext-waker helpers operate on Ext directly.
compio-runtime/src/future/future.rs Updates context helpers to use the new non-generic get_ext/get_waker APIs.
compio-runtime/src/future/combinator/mod.rs Replaces ExtData impl with an inherent Ext::to_owned() used by the waker layer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread compio-runtime/src/waker/ext.rs Resolved
@Berrysoft

Copy link
Copy Markdown
Member

Do you want to handle the check failure here, or in the future?

@George-Miao

Copy link
Copy Markdown
Member Author

@Berrysoft Let's do in a separate PR.

@Berrysoft Berrysoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao
George-Miao added this pull request to the merge queue Apr 6, 2026
Merged via the queue into compio-rs:master with commit 3b7b419 Apr 6, 2026
61 of 66 checks passed
@George-Miao
George-Miao deleted the fix/runtime/ext-waker branch April 6, 2026 16:21
@github-actions github-actions Bot mentioned this pull request Apr 4, 2026
@George-Miao
George-Miao restored the fix/runtime/ext-waker branch April 7, 2026 02:45
@George-Miao
George-Miao deleted the fix/runtime/ext-waker branch April 7, 2026 02:45
This was referenced Apr 21, 2026
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants