Repository navigation
ci: make the latest stable Dapr runtime version lookup reliable - #1732
Open
marcduiker wants to merge 1 commit into
Open
marcduiker wants to merge 1 commit into
marcduiker wants to merge 1 commit into
Conversation
The lookup listed /repos/dapr/dapr/releases?per_page=100, a ~17 MB response that intermittently came back without tag names. curl -s and the export masked the failure, so DAPR_RUNTIME_LATEST_STABLE_VERSION was set to an empty string and the latest-version e2e tests failed with "Invalid Semantic Version" and a nil pointer panic. List the tags with git ls-remote instead, fail the step when no version is found, and stop the status test with t.Fatal when the runtime version cannot be parsed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Marc Duiker <4191277+marcduiker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The KinD and self-hosted E2E workflows find the latest stable Dapr runtime version by listing
https://api.github.com/repos/dapr/dapr/releases?per_page=100, a change from #1720. That response includes every release body and asset list (~17 MB), and it intermittently comes back without anytag_namelines. Because ofcurl -sandexport X=$(...), the step still succeeds and writes an emptyDAPR_RUNTIME_LATEST_STABLE_VERSION.The non-HA tests that install without
--runtime-versionthen fail, for example in #1730:Every KinD run since #1720 has had one or two legs with
Found(empty), on master, release-1.19 and PR branches. A failure only shows up when the empty value lands on a non-HA leg.Changes
git ls-remote --tags --refs https://github.com/dapr/dapr 'v*', which returns only tag names and doesn't count against the API rate limit. It still takes the highest tag without a pre-release suffix, so the GA-day behavior from Run e2e and upgrade tests against Dapr runtime 1.19.0 #1720 is kept.t.Fatalinstead oft.Errorwhen the runtime version can't be parsed inStatusTestOnInstallUpgrade, so a bad version fails the test cleanly instead of panicking on a nil*semver.Versionand aborting the rest of the package.Checklist
go vet -tags e2e,template ./tests/e2e/common/)1.19.0)🤖 Generated with Claude Code