Repository navigation
Conversation
The Helm release name of the control plane was hardcoded to dapr. Allow users to choose it with --release-name on init -k and uninstall -k. upgrade and renew-certificate already look up the release by chart, so they work with a custom name. Fixes dapr#1115 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--release-nameflag todapr init -kanddapr uninstall -kso the Helm release of the control plane no longer has to be calleddapr(#1115). The default staysdapr, so nothing changes for existing users.init: the release name is passed to Helm for the install. The chart pulled is still thedaprchart; I split the chart name from the release name ininstall,getVersionandgetHelmChart, which used one constant for both.uninstall: removes the release with the given name.upgradeandrenew-certificatealready find the release by looking for the Dapr chart among the installed releases, so they work with a custom name without changes.The new tests cover the default and custom name, and lookup of a custom-named release through an in-memory Helm store.
go test ./pkg/kubernetespasses. I did not run the Kubernetes e2e tests since they need a cluster.Fixes #1115