Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Improvements for fonts detection #92

Open

Description

@kannarima

Describe the solution you'd like

  • Font can be changed in dialogue section, so it can be good to check also in dialogue section for fonts used
  • It can be good to take only required variant instead of take all (for example only take bold variant if normal and italic are not used)
  • Sometimes, variant used not exist (for example bold used but only normal exist) but nothing is write in the ASS specs so it have to fallback to normal if bold not exist I think

Activity

  1. moi15moi commented on May 1, 2024

    @moi15moi

    I suggest you to use this package to handle the font selection: https://github.com/moi15moi/FontCollector

    There is currently a pre-release of the 3.0.0.
    If you have any suggestion, feel free to open a issue.

  2. hazylumkun commented on Jan 3, 2025

    @hazylumkun

    maybe you can modify dl.py :
    #659:

    override_pattern = re.compile(r"\{[^}]*\\fn([^\\}]+)[^}]*\}")
    

    #663:

    if line.startswith("Dialogue: "):
        overridden_fonts = [font_name.strip() for font_name in override_pattern.findall(line)]
        font_names.extend(overridden_fonts)
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions