Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
+ Coverage 84.26% 84.27% +0.01%
==========================================
Files 258 258
Lines 56982 56983 +1
Branches 4854 4854
==========================================
+ Hits 48016 48023 +7
+ Misses 8139 8135 -4
+ Partials 827 825 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
reviewed
Oct 21, 2026
mloubout
left a comment
mloubout
left a comment
Contributor
There was a problem hiding this comment.
Looks fine, is unbounded really called thawt much?
Contributor
Author
|
According to profiling, it's enough to cause some amount of overhead? It's a small uplift, but also an easy tweak |
| sdims = search(expr, StencilDimension, mode='unique', deep=True) | ||
|
|
||
| return sdims - bound | ||
| # Immutable, as the cached result is shared across callers |
Contributor
There was a problem hiding this comment.
nitpicking, imho useless comment
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yields moderate compilation speedup for CPML-like operators (possibly others too)