Skip to content

Pin the over-cap derivation-origin test on multidex.ai, not oisy.com - #237

Merged
aterga merged 1 commit into
mainfrom
fix/known-app-test-multidex
Nov 10, 2026
Merged

aterga merged 1 commit into
mainfrom
fix/known-app-test-multidex

Conversation

@aterga

@aterga aterga commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

resolve_app_identity_skips_probe_for_known_apps began failing today. It fails on main and in every PR's CI:

left: Declared
right: Known

oisy.com now serves a real /.well-known/ii-derivation-origin (https://oisy.com, 16 bytes). An app's own declaration takes precedence over the built-in registry by design, so oisy.com correctly resolves as Declared. The test still assumed oisy.com served its app shell at that path.

The test now uses multidex.ai. It is a known app that still answers that path with its app shell (about 190 KB, far over MAX_DERIVATION_ORIGIN_BYTES), so the test pins both of its original properties:

  • a known app is answered by the registry (Known), with no IC probe;
  • an over-cap body reads as "declares nothing", not as a failed check.

It also asserts multidex.ai's registry origin.

Testing

  • cargo test -p imcp2-core: 216 passed.
  • cargo fmt --all -- --check: clean.

This test is live-network, so it will break again if multidex.ai starts declaring its origin. A fixture would make it hermetic; that's left for a follow-up.

🤖 Generated with Claude Code

oisy.com now serves a real /.well-known/ii-derivation-origin
("https://oisy.com"), so it resolves as Declared: the app's own
declaration wins over the built-in registry, as intended. That broke
resolve_app_identity_skips_probe_for_known_apps, which assumed oisy.com
still served its app shell there, and with it CI for every PR.

multidex.ai is a known app that still answers that path with its app
shell (far over MAX_DERIVATION_ORIGIN_BYTES), so the test keeps pinning
both things it was for: a known app is answered by the registry without
an IC probe, and an over-cap body reads as "declares nothing" rather
than a failed check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aterga
aterga requested review from a team and a balanced review from Copilot November 10, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the regression-test target update.

No open issues 🎉

What changed in this PR

Updates a live-network identity-resolution regression test to use multidex.ai, since oisy.com now declares its own derivation origin and no longer exercises registry fallback.

Changes:

  • Switches the known-app and oversized-response test target to multidex.ai.
  • Adds an assertion for its registry derivation origin while retaining the no-probe assertion.
  • Updates comments to explain why the test target changed.
File Description
crates/​imcp2-core/​src/​discover.rs Updates the regression test’s domain, expected origin, and explanatory comments.

Review effort: Balanced

aterga added a commit that referenced this pull request Nov 10, 2026
oisy.com started declaring its own derivation origin, which broke the
live-network test resolve_app_identity_skips_probe_for_known_apps on main
and in every PR's CI. #237 moves the test to multidex.ai. This brings
that one commit in unchanged, so the change collapses into main's copy
once #237 lands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aterga
aterga merged commit a0024b2 into main Nov 10, 2026
17 checks passed
aterga pushed a commit that referenced this pull request Nov 10, 2026
main now carries #237's fix for the stale oisy.com discover test, so the
copy of #238's version this branch carried is dropped in favour of main's
discover.rs, and #200's auth.rs changes merge cleanly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VP2vTJm9ipTPD18xW9HyVG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants