Repository navigation
Pin the over-cap derivation-origin test on multidex.ai, not oisy.com - #237
Merged
Merged
Conversation
oisy.com now serves a real /.well-known/ii-derivation-origin
("https://oisy.com"), so it resolves as Declared: the app's own
declaration wins over the built-in registry, as intended. That broke
resolve_app_identity_skips_probe_for_known_apps, which assumed oisy.com
still served its app shell there, and with it CI for every PR.
multidex.ai is a known app that still answers that path with its app
shell (far over MAX_DERIVATION_ORIGIN_BYTES), so the test keeps pinning
both things it was for: a known app is answered by the registry without
an IC probe, and an over-cap body reads as "declares nothing" rather
than a failed check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the regression-test target update.
No open issues 🎉
What changed in this PR
Updates a live-network identity-resolution regression test to use multidex.ai, since oisy.com now declares its own derivation origin and no longer exercises registry fallback.
Changes:
- Switches the known-app and oversized-response test target to
multidex.ai. - Adds an assertion for its registry derivation origin while retaining the no-probe assertion.
- Updates comments to explain why the test target changed.
| File | Description |
|---|---|
crates/imcp2-core/src/discover.rs |
Updates the regression test’s domain, expected origin, and explanatory comments. |
Review effort: Balanced
sea-snake
approved these changes
Nov 10, 2026
aterga
added a commit
that referenced
this pull request
Nov 10, 2026
oisy.com started declaring its own derivation origin, which broke the live-network test resolve_app_identity_skips_probe_for_known_apps on main and in every PR's CI. #237 moves the test to multidex.ai. This brings that one commit in unchanged, so the change collapses into main's copy once #237 lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aterga
pushed a commit
that referenced
this pull request
Nov 10, 2026
main now carries #237's fix for the stale oisy.com discover test, so the copy of #238's version this branch carried is dropped in favour of main's discover.rs, and #200's auth.rs changes merge cleanly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VP2vTJm9ipTPD18xW9HyVG
Draft
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_app_identity_skips_probe_for_known_appsbegan failing today. It fails on main and in every PR's CI:oisy.com now serves a real
/.well-known/ii-derivation-origin(https://oisy.com, 16 bytes). An app's own declaration takes precedence over the built-in registry by design, so oisy.com correctly resolves asDeclared. The test still assumed oisy.com served its app shell at that path.The test now uses multidex.ai. It is a known app that still answers that path with its app shell (about 190 KB, far over
MAX_DERIVATION_ORIGIN_BYTES), so the test pins both of its original properties:Known), with no IC probe;It also asserts multidex.ai's registry origin.
Testing
cargo test -p imcp2-core: 216 passed.cargo fmt --all -- --check: clean.This test is live-network, so it will break again if multidex.ai starts declaring its origin. A fixture would make it hermetic; that's left for a follow-up.
🤖 Generated with Claude Code