VC 2.0 Release Canidate by aljones15 · Pull Request #148 · digitalbazaar/vc

aljones15 · 2023-07-24T16:53:01Z

Features:

Issues and Verifies VCs using the 1.0 and 2.0 VC Data Models
Has integration tests for VCs using both models
Has validators for validUntil and validFrom
Updates the timestamp validator to use the XML standard from the spec
includes an expanded suite with timestamp tests

NOTE:
new features in the VC 2.0 release should branch from this PR unless they build on another feature in a sister PR.

TODO:

Addresses:
#149 (comment)

JSAssassin · 2023-08-11T14:37:58Z

@aljones15 IMO we should drop support for Node 14 and 16 and that can be addressed in a separate PR.

aljones15 · 2023-08-11T15:24:42Z

@aljones15 IMO we should drop support for Node 14 and 16 and that can be addressed in a separate PR.

awesome thanks for letting me, node 14 tests are failing probably because of the branches.

OR13 · 2023-09-17T17:11:56Z

When this get's merged we will want to update the various plugins that build examples.

aljones15 · 2023-09-18T17:19:26Z

When this get's merged we will want to update the various plugins that build examples.

@OR13 this branch was used for the test suite for VC 2.0, but as that spec is still in progress, we might not release this build of this library. This PR also still lacks a few VC 2.0 features such as validUntil and validFrom. So this PR is not currently prioritized to my knowledge for merge or release.

JSAssassin · 2023-12-05T18:56:49Z

+        if(result.error) {
+          const firstError = [].concat(result.error)[0];
+          throw firstError;
+        }


why is this needed here and in other places?

This is actually not my code or part of this PR, but I do know that the VC library doesn't throw in all cases, verification can return an error or an array of errors. it looks like this code takes that error which could be an array, ensures it is an array and then throws the first error. We probably should be asserting on that error. Maybe an issue can be made about this to assert on these errors rather than throw? EDIT: in most cases it looks like we don't want to assert on the error, and that this code ensures that positive tests throw if an error occurs in verification as this library often doesn't throw when verifying.

@dmitrizagidulin got any insight here? it looks like you just wanted to throw if there is an error so you could check it and figure out what was going wrong with this lib?

codecov-commenter · 2023-12-06T16:53:00Z

Codecov Report

Attention: Patch coverage is 90.85366% with 30 lines in your changes missing coverage. Please review.

Project coverage is 90.46%. Comparing base (be05032) to head (203d698).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   88.66%   90.46%   +1.79%     
==========================================
  Files           4        5       +1     
  Lines         812     1059     +247     
==========================================
+ Hits          720      958     +238     
- Misses         92      101       +9

Files	Coverage Δ
lib/contexts/index.js	`100.00% <100.00%> (ø)`
lib/helpers.js	`92.39% <92.39%> (ø)`
lib/index.js	`90.70% <89.68%> (+1.64%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be05032...203d698. Read the comment docs.

JSAssassin

Thanks! LGTM.

… test contexts.

…Date test data.

…C 1.0 checks.

Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>

…stamp. Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>

- Make "id" optional. - If "id" present, check it's a URL. - Add tests.

Co-authored-by: BigBlueHat <byoung@bigbluehat.com>

aljones15 · 2024-05-17T23:05:45Z

 export default {
-  CREDENTIALS_CONTEXT_URL: 'https://www.w3.org/2018/credentials/v1',
+  CREDENTIALS_CONTEXT_URL: 'https://www.w3.org/ns/credentials/v2',
+  CREDENTIALS_CONTEXT_V1_URL: 'https://www.w3.org/2018/credentials/v1',


@aljones15 maybe we need a CREDENTIALS_CONTEXT_V2_URL here?

- Switch from `credentials-context` to `@digitalbazaar/credentials-context`. - Use all contexts from `@digitalbazaar/credentials-context`. - Simplify context packages usage by using exported `contexts` directly. - Improve credentials context mapping to and from versions. - Use explicit maps. - Expose a helper function.

aljones15 · 2024-08-01T19:07:38Z

@davidlehn obviously leave the branch update-vc-2.0 so other builds still work with it for now.

aljones15 self-assigned this Jul 24, 2023

aljones15 requested a review from davidlehn August 4, 2023 15:12

This was referenced Aug 11, 2023

Add support for Verifiable Credentials Data Model v2.0 #149

Closed

Add ability to sign v2 Verifiable Credentials. #133

Closed

aljones15 force-pushed the update-vc-2.0 branch 2 times, most recently from d9d7ba4 to dcecf7b Compare November 28, 2023 14:54

JSAssassin suggested changes Dec 5, 2023

View reviewed changes

aljones15 force-pushed the update-vc-2.0 branch 2 times, most recently from ec59695 to 8d114c3 Compare December 6, 2023 14:39

aljones15 force-pushed the update-vc-2.0 branch from fc2a605 to 02c9701 Compare December 7, 2023 14:35

aljones15 requested a review from JSAssassin December 7, 2023 21:16

JSAssassin approved these changes Dec 8, 2023

View reviewed changes

aljones15 changed the title ~~Update vc 2.0~~ VC 2.0 Release Canidate Dec 8, 2023

aljones15 force-pushed the update-vc-2.0 branch from dbaf8c8 to fdc98f6 Compare December 8, 2023 19:24

aljones15 requested a review from BigBlueHat January 11, 2024 15:49

aljones15 added the VC 2.0 label Feb 5, 2024

aljones15 mentioned this pull request Mar 15, 2024

VC 2.0 add integration tests for language and base direction #175

Open

aljones15 force-pushed the update-vc-2.0 branch from 9ff44fe to 4f59e13 Compare April 19, 2024 21:07

aljones15 added 7 commits May 17, 2024 22:55

Add credentials v2 context to deps.

e427341

Add credentials v2 context to doc loader and check for it.

8b80e8c

Add credentials context V2 to test contexts.

5b8c7cd

Add invalid and valid contexts to test suite & add ed25519 context to…

cc6c1a8

… test contexts.

Make VC v2 context default.

f671efb

Add issuanceDate to v1 VCs, validate issuanceDate v1, remove issuance…

a8f7f7f

…Date test data.

Add contexts, testLoader, & documentLoader to separate files.

b2f342d

aljones15 and others added 15 commits May 17, 2024 22:56

Assert on error messages for validUntil and validBefore.

0145936

Date checks return datetime verbatim & use seconds in test data.

1e78e22

Use mockCredential() in validFrom & validUntil same time test.

304a4e5

Move expirationDate test to v1 tests & use mockCredential in all tests.

37b8f50

Add issuanceDate format check under issuanceDate existence check in V…

0541875

…C 1.0 checks.

Check validUntil & validFrom format on issue.

d537b0a

Update lib/index.js clarify jsdoc comments about issuanceDate.

0cb9ef1

Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>

Update test/10-verify.spec.js remove extra blank line.

d3b5192

Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>

Update test/helpers.js use substring & template string for date time …

8a27874

…stamp. Co-authored-by: Tashi D. Gyeltshen <38434620+JSAssassin@users.noreply.github.com>

Remove extra semicolon from inline github code edit.

99ce9c4

Update credentialStatus checks.

e8f9ee4

- Make "id" optional. - If "id" present, check it's a URL. - Add tests.

Fix credentialStatus id test typos.

c5cbb8b

Update test/10-verify.spec.js remove ref to validAfter in jsdoc comment.

4cb4be3

Co-authored-by: BigBlueHat <byoung@bigbluehat.com>

Update CHANGELOG.md remove validAfter from CHANGELOG.

c38c608

Co-authored-by: BigBlueHat <byoung@bigbluehat.com>

Import mock.data in verify & export credentials from mock.data.

c22021f

aljones15 force-pushed the update-vc-2.0 branch from d3abfab to c22021f Compare May 17, 2024 22:58

aljones15 commented May 17, 2024

View reviewed changes

aljones15 and others added 9 commits July 6, 2024 13:24

Style nit: ensure credentials includes version.

7ff844b

Add Credentials Contet V2 URL to test constants.

1e10280

Make more explicit context url version used in mock data.

617b9bd

Remove unusued CREDENTIALS_CONTEXT_URL from test constants.

203d698

Remove unused import.

26eedff

Update changelog.

464c051

Use context package named Map for context URLs.

90df214

Update dev dependencies.

5bb3e76

davidlehn marked this pull request as ready for review August 1, 2024 19:02

davidlehn approved these changes Aug 1, 2024

View reviewed changes

davidlehn merged commit 857a7b8 into main Aug 1, 2024

Conversation

aljones15 commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JSAssassin commented Aug 11, 2023

Uh oh!

aljones15 commented Aug 11, 2023

Uh oh!

OR13 commented Sep 17, 2023

Uh oh!

aljones15 commented Sep 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JSAssassin Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

aljones15 Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aljones15 Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JSAssassin left a comment

Choose a reason for hiding this comment

Uh oh!

aljones15 May 17, 2024

Choose a reason for hiding this comment

Uh oh!

aljones15 commented Aug 1, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aljones15 commented Jul 24, 2023 •

edited

Loading

aljones15 Dec 6, 2023 •

edited

Loading

codecov-commenter commented Dec 6, 2023 •

edited

Loading