Repository navigation
Conversation
Added tests for collider reparenting behavior, ensuring that invalid parent handles do not alter existing relationships and standalone colliders remain unaffected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1021.
ColliderSet::set_parentremoved the collider from its current body's collider list and overwrote the stored parent before validating the requestedRigidBodyHandle. Passing a stale or invalid handle left a dangling parent, and the nextPhysicsPipeline::steppanicked while processing the change.The method now checks that the requested parent exists first and returns without touching either set when it does not, so an invalid reparent is a no-op.
Regression tests cover a never-valid handle and a stale generational handle (both preserve the existing relationship and survive a step), plus valid reparent and detach behavior. The doc comment notes the new no-op behavior.
Tested:
cargo test -p rapier3d84/84 andcargo test -p rapier2d66/66.