Repository navigation
Conversation
tonistiigi
reviewed
Oct 13, 2026
tonistiigi
left a comment
tonistiigi
left a comment
Member
There was a problem hiding this comment.
Is there a point of verifying ambiguous behavior if we are not sure what any particular buildx instance does.
I think we should either just skip this case or add a test with 1.27 build tag and strict expected behavior.
IDNA's Unicode 15 tables normalize the invalid UTF-8 hostname to punycode, while the Unicode 17 tables selected by Go 1.27 reject it. Remove this version-dependent case from the normalization tests so they pass on both toolchains without accepting ambiguous behavior. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-policy-idna-test
branch
from
October 13, 2026 12:06
4b13a0c to
00413ec
Compare
crazy-max
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4138
Remove the invalid UTF-8 hostname case from the normalization tests. IDNA's Unicode 15 tables normalize it to punycode, while the Unicode 17 tables selected by Go 1.27 reject it.