Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an agent stops responding, its Azure DevOps job can stay
inProgresswithresult: nullfor hours, even though the timeline already shows an agent-loss error on the job and acompletedparentPhase. The Helix Job Monitor waits for every non-monitor job to reachcompleted, so in that state it keeps running until its own timeout.Abandoned-job detection (
HelixJobMonitorUtilities)issues(newAzureDevOpsTimelineIssuetype).GetAbandonedNonMonitorJobRecordsreturns non-monitor jobs that are notcompletedand match either signal:errorissue whose message containsWe stopped hearing from agentorAgents can't recover from restarts.Phaserecord iscompleted. This catches cases where the error text doesn't match, such as the Windows "remote provider deprovision" example in the issue comments.AreNonMonitorJobsCompletecounts abandoned jobs as finished, andHasFailedNonMonitorJobscounts them as failed.Runner and reporting
JobMonitorRunnerlogs one warning per abandoned job (de-duplicated across polls) through the newStatusReporter.LogAbandonedPipelineJob.Docs and tests
Design/SemanticBehavior.md§5.4 (termination step) now covers abandoned jobs.HelixJobMonitorUtilitiesTestsadds cases for:Review notes
completedwhile one of its jobs is still legitimately running. That held for every reported case, but it is not confirmed with Azure DevOps.To double check: