Repository navigation
[vs18.9] Remove redundant internal tools restore - #15500
Merged
JanProvaznik merged 1 commit intoNov 9, 2026
Merged
JanProvaznik merged 1 commit into
JanProvaznik merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
AlesProkop
had a problem deploying
to
copilot-pat-pool
November 9, 2026 12:23 — with
GitHub Actions
Failure
ViktorHofer
approved these changes
Nov 9, 2026
AlesProkop
had a problem deploying
to
copilot-pat-pool
November 9, 2026 12:26 — with
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the targeted restore-step removal and servicing-version update.
No open issues 🎉
What changed in this PR
This narrowly backports the redundant internal-tools restore removal from #14352 to vs18.9, avoiding an early restore that could select Visual Studio MSBuild before the repository’s pinned SDK is bootstrapped.
Changes:
- Removes the early
NuGetCommand@2restore step, relying on the normaleng/CIBuild.cmd -restorepath. - Bumps the servicing version from
18.9.23to18.9.24.
| File | Description |
|---|---|
| eng/Versions.props | Updates the servicing version to 18.9.24. |
| azure-pipelines/.vsts-dotnet-build-jobs.yml | Removes the redundant pre-bootstrap internal-tools restore step. |
Review effort: Balanced
JanProvaznik
approved these changes
Nov 9, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15497
Context
Official build 20261109.6 failed in the early internal-tools restore because NuGet selected the installed Visual Studio MSBuild before the repository bootstrapped its pinned SDK. This narrowly backports the redundant restore-step removal from #14352; the normal
eng/CIBuild.cmd -restorepath restores internal tooling after SDK bootstrap.Changes Made
NuGetCommand@2Restore internal toolsstep fromazure-pipelines/.vsts-dotnet-build-jobs.yml.VersionPrefixfrom18.9.23to18.9.24ineng/Versions.props.Testing
azure-pipelines/.vsts-dotnet-build-jobs.ymlwith PowerShellConvertFrom-Yamland verified the removed step is absent and the remaining task order is preserved — passed.eng/Versions.propsas XML and verifiedVersionPrefixis18.9.24with no other branding changes — passed.eng/CIBuild.cmdthroughInitializeToolset,InitializeBuildTool, andInitializeDotNetCli— verified SDK bootstrap remains before toolset restore.git diff --check— passed.Notes