Skip to content

[vs18.9] Remove redundant internal tools restore - #15500

Merged
JanProvaznik merged 1 commit into
dotnet:vs18.9from
AlesProkop:alesprokop-vs18-9-internal-tools-restore
Nov 9, 2026
Merged

JanProvaznik merged 1 commit into
dotnet:vs18.9from
AlesProkop:alesprokop-vs18-9-internal-tools-restore

Conversation

@AlesProkop

Copy link
Copy Markdown
Member

Related to #15497

Context

Official build 20261109.6 failed in the early internal-tools restore because NuGet selected the installed Visual Studio MSBuild before the repository bootstrapped its pinned SDK. This narrowly backports the redundant restore-step removal from #14352; the normal eng/CIBuild.cmd -restore path restores internal tooling after SDK bootstrap.

Changes Made

  • Removed the early NuGetCommand@2 Restore internal tools step from azure-pipelines/.vsts-dotnet-build-jobs.yml.
  • Bumped VersionPrefix from 18.9.23 to 18.9.24 in eng/Versions.props.

Testing

  • Parsed azure-pipelines/.vsts-dotnet-build-jobs.yml with PowerShell ConvertFrom-Yaml and verified the removed step is absent and the remaining task order is preserved — passed.
  • Parsed eng/Versions.props as XML and verified VersionPrefix is 18.9.24 with no other branding changes — passed.
  • Inspected the checked-in restore path from eng/CIBuild.cmd through InitializeToolset, InitializeBuildTool, and InitializeDotNetCli — verified SDK bootstrap remains before toolset restore.
  • Ran git diff --check — passed.

Notes

  • No manual official, OptProf, or ExpPerf build was queued; automatic PR CI is the first official build validation for this change.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@AlesProkop
AlesProkop requested a review from a team as a code owner November 9, 2026 12:22
Copilot AI balanced review requested due to automatic review settings November 9, 2026 12:22
@AlesProkop
AlesProkop deployed to copilot-pat-pool November 9, 2026 12:22 — with GitHub Actions Active
@AlesProkop
AlesProkop deployed to copilot-pat-pool November 9, 2026 12:22 — with GitHub Actions Active
@AlesProkop
AlesProkop deployed to copilot-pat-pool November 9, 2026 12:25 — with GitHub Actions Active
@AlesProkop
AlesProkop deployed to copilot-pat-pool November 9, 2026 12:26 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the targeted restore-step removal and servicing-version update.

No open issues 🎉

What changed in this PR

This narrowly backports the redundant internal-tools restore removal from #14352 to vs18.9, avoiding an early restore that could select Visual Studio MSBuild before the repository’s pinned SDK is bootstrapped.

Changes:

  • Removes the early NuGetCommand@2 restore step, relying on the normal eng/CIBuild.cmd -restore path.
  • Bumps the servicing version from 18.9.23 to 18.9.24.
File Description
eng/​Versions.props Updates the servicing version to 18.9.24.
azure-pipelines/​.vsts-dotnet-build-jobs.yml Removes the redundant pre-bootstrap internal-tools restore step.

Review effort: Balanced

@JanProvaznik
JanProvaznik merged commit 24c824b into dotnet:vs18.9 Nov 9, 2026
17 of 19 checks passed

This branch had an error being deployed

1 failed deployment
copilot-pat-pool — 19c8a27d Deployed Nov 9, 2026 by AlesProkop via conclusion #1128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants