Skip to content

Fix EventPipe shutdown logic - #86180

Merged
davmason merged 1 commit into
dotnet:mainfrom
davmason:eventpipe_threadfix
May 15, 2023
Merged

davmason merged 1 commit into
dotnet:mainfrom
davmason:eventpipe_threadfix

Conversation

@davmason

Copy link
Copy Markdown
Contributor

A typo from #78852 means we weren't waiting for threads to finish writing events before shutting down the session.

Fixes #85261
Fixes #86134
Fixes #85213
Fixes #84813

Update ep-thread.c
@davmason davmason added this to the 8.0.0 milestone May 12, 2023
@davmason
davmason requested review from a team and lateralusX May 12, 2023 20:57
@davmason davmason self-assigned this May 12, 2023
@ghost ghost added the area-Tracing-coreclr label May 12, 2023

@lateralusX lateralusX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@lateralusX

Copy link
Copy Markdown
Member

This will most likely fix #84257 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.