Repository navigation
Test Spool on Apple Silicon macOS - #18
Merged
Merged
Conversation
Closed
11 of 14 tasks
Test both Ctrl and Cmd on every platform, stop assuming any template card is on the chooser's first screen, and share one input upload helper. Move the dated Mac validation record into the pull request and keep test-harness notes out of the user guide and changelog.
doubletwisted
force-pushed
the
test-spool-on-mac
branch
from
October 28, 2026 02:32
86ba195 to
67ea30d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh Apple Silicon install exposed browser checks that required Windows shortcut labels and a pre-existing template image. The checks now accept the platform's shortcut labels, press both Ctrl and Cmd, create their own template input, and search ComfyUI's virtualized chooser.
Updates the README, changelog and macOS package classifier. macOS stays experimental: compatible Desktop/Dock testing and the exact quarantined-launcher recovery remain in #17. Refs #14.
Validation:
Apple Silicon validation record
Real-machine evidence for #14,
recorded on 2026-10-28. macOS remains experimental; the remaining Desktop and
downloaded-launcher acceptance is tracked in
#17.
Environment
.venv426f5eea52a7ece1dd599fff4cb6cd1f352ddd24ComfyUI was cloned into a disposable folder with its own virtual environment.
Node and ffmpeg were also local to that folder; Homebrew and system packages
were not installed. Existing Chrome and Python were reused. Browser and live
checks used
tests/run_host.py, isolated projects, media and credentials.The browser host loaded Partner Node schemas and the Deadline plugin solely
for workflow/bridge checks. No Cloud or farm jobs were submitted.
Automated evidence
python tests/run_architecture_checks.py: 314 Python tests (one Windows-onlystreaming check skipped), plus all 24 JavaScript suites, passed.
run_browser_checks.cjsscenario passed on native macOS:74 scenarios, 1,416 assertions. After fixing the failures below, the remaining
scenarios were resumed in separate runs; this was not one uninterrupted run.
take-file-actions,clip-folderandinspector-notesalso passed togetheras explicit named checks, without
-macemulation.verify_live.py: all 19 checks passed using genuine CPU image/video rendersand ffmpeg. This covered collection, unchanged take choice, frozen inputs,
backup/import, restart recovery, byte-range seeking, cached cut detection,
source-rate interpretation, MP4/audio export and OTIO references.
verify_agent_live.py: all five checks passed, including scoped CLI variantsqueued while ComfyUI was stopped and collected after restarting it. Its first
run collided with the Finder-launched standalone server on its fixed port
8190; the successful run used a free port after stopping that server.
The architecture gate contains mocked execution-adapter tests. Browser checks
use intercepted frontend assets and some fixture responses (including Cloud,
offline and file-action checks). Those results do not establish live Cloud or
farm support. The CPU live checks and native actions below are separate live
evidence. Paid
cloud-smokeand the two opt-in profiling/capture checks wereexcluded from the default browser run.
Native actions
run_spool.commandstarted standaloneSpool, used ComfyUI's
.venv, and opened the default browser without aGatekeeper prompt.
sh run_spool.sh --port 8191launched from another working directory usedthe same virtual environment and served a healthy studio.
.shand an executable launcher with a space in itspath started real ComfyUI through standalone startup settings. The host paired
successfully and survived termination of its standalone parent process.
A real settings request rejected a non-script, non-executable file with the
ComfyUI Desktop guidance.
opened the actual clip folder. A copied video appeared automatically as a
New take without replacing the chosen take.
Cmd and Option. In a normal Chrome window with a disposable profile,
Cmd+D duplicated, Cmd+Z undid, Cmd+Shift+Z redid, Cmd+A selected all clips,
Cmd+S saved, and Cmd+Enter added a note. Chrome did not intercept these keys.
and decoded picture visible. This smoke check does not establish Safari
support.
into two 15-frame shots.
through an isolated loopback server and expanded by Archive Utility. The
launcher retained mode
0755and Safari's quarantine attribute. Double-clickdid not start Spool; Gatekeeper/XProtect logged an executable assessment.
Automation could not inspect Terminal's dialog or verify a recovery path.
No quarantine attribute or security setting was bypassed.
Test corrections
Two browser assertions expected Windows shortcut labels (
Ctrl+Z,Ctrl+S).The UI already displayed the correct Mac labels; the label checks now use the
platform's wording. Take-removal keyboard checks press both Ctrl and Cmd on every
platform, as the studio accepts either, including trusted CDP Undo/Redo and Undo
after reload.
The embedded-template check also assumed LTX and MiniMax cards were rendered on
the first screen of ComfyUI's virtualized catalog and that
generation-controls.pngalready existed on the host. It now searches for LTX on each chooser opening
and uploads its own source fixture before opening ComfyUI. These were test
assumptions exposed by a fresh install, rather than demonstrated Mac defects.
Scope
Studio buttons, menus, keyboard shortcuts and the inspector were exercised;
the Comfy page entry and real graph/Apply bridge were included in the browser
suite. Both the installed extension host and standalone Spool were checked.
Local execution has real CPU evidence; Cloud has mocks only, and Deadline has
contract/schema coverage without a real farm. No shared Python/JavaScript wire
format changed.
This run does not establish Intel Mac support, Apple GPU/model performance,
Linux support, or production-scale video performance. Desktop's Dock PATH and
standalone pairing require a compatible Desktop build: the latest inspected
Desktop release, v0.9.4, bundled ComfyUI 0.22.3, below Spool's minimum 0.39.0.