Skip to content
This repository was archived by the owner on Sep 15, 2026. It is now read-only.

adjust typing to mirror changes in getAccessToken - #85

Merged
dylanirlbeck merged 3 commits into
draftbit:masterfrom
maybeanerd:issue-78-TS-adjustments
Apr 24, 2020
Merged

dylanirlbeck merged 3 commits into
draftbit:masterfrom
maybeanerd:issue-78-TS-adjustments

Conversation

@maybeanerd

@maybeanerd maybeanerd commented Apr 24, 2020 •

Copy link
Copy Markdown
Contributor

As corrected in #79 , the inputs have changed.
After remembering that typing had been added, the types needed to also be adjusted. This PR takes care of that.

After looking at the documentation again, I could confirm my assumption that key and secret are not part of the request.
Therefore the type and function have been adjusted to include this change.

- remove key , secret as they are in no way mentioned in the docs and were not even included in the original type
- make oauth token required even for pin use, as the docs state: The oauth_token here must be the same as the oauth_token returned in the request_token step.
- adjust readme
@maybeanerd

Copy link
Copy Markdown
Contributor Author

I just tested it again, and it works just as intended.
Key and Secret are in no way needed.

@dylanirlbeck dylanirlbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM! Not sure where key or secret were being used originally (I had no part in oauth), but I don't see them on the Twitter docs.

@AdilHoumadi

Copy link
Copy Markdown

Hello @dylanirlbeck,
I am still getting the same issue as stated in the first issue.
[Object: null prototype] { 'Request token missing': '' }
Can you release/pre-release this fix please ?

Thank you.

@dylanirlbeck

Copy link
Copy Markdown
Contributor

Hi @AdilHoumadi ! Sorry you're still having this issue, we should have a release out sometime tomorrow --- I'll ping you here when we do.

@peterpme

Copy link
Copy Markdown
Contributor

Published at 0.11.0 @AdilHoumadi. Thanks!

@AdilHoumadi

Copy link
Copy Markdown

@dylanirlbeck, @peterpme, Thank you 👍

@maybeanerd

Copy link
Copy Markdown
Contributor Author

glad my bugfixes were needed so quickly 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants