Repository navigation
fix(lunar): reject months, days and leap months that do not exist - #397
Merged
gouguoyin merged 1 commit intoNov 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lunar.NewLunarandcarbon.CreateFromLunaronly check that the year is in range, so a date that does not exist is accepted and converted to a real Gregorian day with no error:The offset math in
ToGregorianjust adds the day to the start of the month, so an impossible date rolls into the next month instead of failing. Month 0 and day 0 go backwards the same way.IsValidnow also checks that the month is 1 to 12, that the day fits the month (usinggetDaysInMonth/getDaysInLeapMonth), and that a leap month is the year's actual leap month. While there I fixed the error text inNewLunar, which said "invalid persian date" and checkedIsValidtwice.To make sure nothing valid is rejected, I ran every day from 1900-01-31 to 2101-01-28 through
FromStdTime, rebuilt it withNewLunarand converted it back withToGregorian. All 73,384 days passed both checks.The new cases in
TestLunar_IsValidandTestCreateFromLunarfail on master and pass with this change.go test ./...andgo vet ./...pass.