Skip to content

Lab 4 implementation - #1747

Draft
zhodino-byte wants to merge 4 commits into
ed-donner:mainfrom
zhodino-byte:lab-4-implementation
Draft

zhodino-byte wants to merge 4 commits into
ed-donner:mainfrom
zhodino-byte:lab-4-implementation

Conversation

@zhodino-byte

Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Nov 12, 2026
@ed-donner
ed-donner marked this pull request as draft November 12, 2026 03:33
@ed-donner

Copy link
Copy Markdown
Owner

Hi @zhodino-byte,

I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged, so please can I ask you to review this:

https://edwarddonner.com/pr

In this PR, your lab 4 and lab 5 notebooks are fine, but the PR also changes the course's 1_foundations/1_lab1.ipynb, from the "Finished lab1 notebook" commit on your fork's main, and 1_foundations/5_extra.ipynb, and your twin folder includes resume.pdf and requirements.txt, which the guide asks to leave out. Please put the two lab notebooks back as they are on main, remove those two files, and push to this branch.

The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions.

If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!)

The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above.

The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large.

The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0.

I've set this PR to draft for now, so I can see at a glance which PRs are ready for me. When you've made the change, click "Ready for review" near the bottom of this page and I'll take a look. I very much look forward to merging it!

Thanks so much
Ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants