Repository navigation
Week 2 lab 1 implementation - #1750
zhodino-byte wants to merge 5 commits into
Conversation
|
Hi @zhodino-byte, I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged, so please can I ask you to review this: In this PR, your week 2 lab 1 notebooks are fine, but the PR also brings in your Lab 3 files from #1745, including Profile.pdf, and the change to the course's 1_foundations/1_lab1.ipynb. Both come from your fork's main, where this branch started. Please take the Lab 3 files out of this branch and put 1_lab1.ipynb back as it is on main, so the PR only has your files in 2_openai/community_contributions, and push to this branch. The same goes for #1752, #1754 and #1760. If it's easier, you're also welcome to open a new PR from a branch that starts at the latest main of ed-donner/agents, with just your own files, and close this one. The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions. If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!) The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above. The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large. The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0. I've set this PR to draft for now, so I can see at a glance which PRs are ready for me. When you've made the change, click "Ready for review" near the bottom of this page and I'll take a look. I very much look forward to merging it! Thanks so much |
No description provided.