Repository navigation
fix: make test_script.py directory portable and configurable - #113
Open
muskan-creates352 wants to merge 1 commit into
Open
muskan-creates352 wants to merge 1 commit into
muskan-creates352 wants to merge 1 commit into
Conversation
Replaces the hardcoded personal developer path in test_script.py with a dynamic path pointing to the repository's sample lightweight PDF corpus, with support for GLOSSAPI_TEST_DIR environment variable or CLI argument overrides. Fixes eellak#112
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #112
In
test_script.py(line 12), the test directory was previously hardcoded to an absolute personal local developer directory (/home/fivos/CascadeProjects/glossAPI/corpus_test), causing aFileNotFoundErrorwhen executed on external environments.This PR makes
test_script.pyportable by:__file__.samples/lightweight_pdf_corpus/pdfs) and writing outputs toartifacts/test_run.GLOSSAPI_TEST_DIRenvironment variable or a command-line argument (python test_script.py /path/to/corpus).Changes
test_script.py: Addedget_test_dirs()helper to dynamically resolve input and output directories with fallback to sample data.Testing
python test_script.pyresolves directories out of the box without requiring manual path edits.