Repository navigation
Conversation
Assisted-By: Hermes Agent
a5768549
force-pushed
the
feat/template-initial-visibility
branch
from
November 3, 2026 04:49
3f0b2f8 to
62ccfbb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4436.
Set
show: falsein the base, Vite, and webpack templates, and register a one-timeready-to-showlistener before loading the renderer. The window is shown after its initial render rather than immediately at construction. Existing preload configuration, development/production load paths, DevTools, and activation handling are preserved.The template comments link to Electron's graceful-display documentation and explain that this does not wait for application-specific initialization, requires the default
paintWhenInitiallyHiddenbehavior, and can be replaced with immediate display plusbackgroundColor. This changes newly generated example applications, not Forge runtime behavior or existing projects.Add regression tests that generate the JavaScript/TypeScript variants through the template APIs and execute their main-process code with controlled Electron events. They cover hidden initial state, one-time display, load targets, and window recreation on activation.
Validation
Commands used the repository-pinned Yarn CLI (
node .yarn/releases/yarn-4.18.0.cjs) on Windows.build,lint:js,constraints,knip, template formatting, andgit diff --checkpassed. Existing unrelatedno-explicit-anywarnings remain.ready-to-show, and visibility afterward. Vite/webpack used data-URL renderer fixtures, not bundled or packaged applications; base used its template HTML. Base/webpack emitted GPU exit-code diagnostics, while the assertions and processes passed.Not validated: macOS/Linux or complete slow/Verdaccio packaging tests.
test:verdaccio packages/templatefailed during local publication withECONNREFUSED 127.0.0.1:4873before tests ran. No public registry publication occurred. Full markdown/link lint was not run.AI assistance
Hermes Agent assisted with the implementation, tests, and this description. The human contributor reviewed the complete four-file diff and explicitly approved submission. AI assistance is also disclosed in the commit trailer.