Skip to content

Feature request: environment variable to respect the -shared flag #16481

New issue
New issue
Open
Open
Feature request: environment variable to respect the -shared flag#16481

Description

@hoodmane
hoodmane
opened on Mar 12, 2022

In Pyodide, we run into a fair amount of trouble convincing various build systems to pass -s SIDE_MODULE=1 through to the compiler. Also, if a library asks to be -shared we always want to respect it. I finally thought to just patch

emscripten/emcc.py

Line 1565 in ebe0ddd

diagnostics.warning('emcc', 'linking a library with `-shared` will emit a static object file. This is a form of emulation to support existing build systems. If you want to build a runtime shared library use the SIDE_MODULE setting.')

to set settings.SIDE_MODULE = True but it would be helpful to have a feature for this.

Activity

  1. hoodmane commented on Mar 12, 2022

    @hoodmane
    hoodmane
    on Mar 12, 2022
    CollaboratorAuthor

    The comment there says:

     # Until we have a better story for actually producing runtime shared libraries
 # we support a compatibility mode where shared libraries are actually just
 # object files linked with `wasm-ld --relocatable` or `llvm-link` in the case
 # of LTO.

    But Emscripten has a good system for producing shared libraries =)

  2. sbc100 commented on Mar 13, 2022

    @sbc100
    sbc100
    on Mar 13, 2022
    Collaborator

    Perhaps related: #16281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions