Repository navigation
Prevent ConcurrentModificationException - #27
Merged
Merged
Conversation
Changed WeakHashMap to HashMap to get callbacks work
rejoinTimerTask runs rejoinUntilConnected() which checks for the current channel\socket state and either rejoin channel or schedule the next check. So the task must be set to start only once after each check.
rejoinTimerTask runs rejoinUntilConnected() which checks for the current channel\socket state and either rejoin channel or schedule the next check. So the task must be set to start only once after each check. Current behaviour leads to the memory allocation error and application crash in case of the network problems.
This fix javaCompile error during gradle build.
Callbacks are garbage collecting in case of using WeakHashMaps
Change scheduleRepeatingTask() to scheduleTask()
Fix TargetCompability of Java
Owner
|
Thanks @Mobbit - could you please split the PR so I can merge the ConcurrentModificationException fix? Source compatibility is already merged. It'd be good to know what the goal of adding gradlew and those other gradle bits is. |
Contributor
Author
|
@eoinsha Sure, will do it. The reason was that jitpack.io failed to build without it. A gradle wrapper is used to use a gradle version per project instead of the globally installed gradle. |
Owner
|
Thanks @Mobbit 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The for loop in
src/main/java/org/phoenixframework/channels/Socket.javacould cause anConcurrentModificationExceptionin our project. Thesynchronizedblock should prevent that.I also updated gradle.