Skip to content

Free organizations can connect Slack, but no Slack notifications are ever sent #2702

Open

Description

@ejsmith

A project in a Free plan organization can connect Slack, and the app reports success. Notifications are never queued for organizations without premium features, so the Slack channel never receives anything, and nothing in the UI says why. If the user changes the Slack notification switches afterwards, they get a generic error instead of the upgrade dialog.

Where

Steps to reproduce

  1. In an organization on the Free plan, open a project's Integrations page and click Connect Slack.
  2. Complete the Slack authorization. The app shows "Successfully connected Slack integration" and default Slack settings are saved.
  3. Send a new error to the project. Nothing arrives in Slack.
  4. Toggle any Slack notification setting. The app shows "Error updating Slack notification settings. Please try again." because the 426 isn't handled.

Expected

Connecting Slack on the Free plan returns the plan-limit error (426) before the OAuth token is stored, and the page shows the upgrade dialog, as it already does for webhooks. Settings changes also show the upgrade dialog instead of a generic error.

Suggested fix

  • In AddProjectSlack, load the organization and return the same PlanLimit validation result used in SetProjectIntegrationNotificationSettings when !organization.HasPremiumFeatures. Ideally check this before exchanging the code, or revoke the token afterwards.
  • In updateSlackNotificationSettings, call showBillingDialogOnUpgradeProblem.
  • Optionally show a notice on the Slack section for organizations already connected on the Free plan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions