Skip to content

Fix self-hosting config bugs - #2715

Open
ejsmith wants to merge 5 commits into
mainfrom
fix/server-config-issues
Open

ejsmith wants to merge 5 commits into
mainfrom
fix/server-config-issues

Conversation

@ejsmith

@ejsmith ejsmith commented Nov 4, 2026

Copy link
Copy Markdown
Member

Small, verified fixes for self-hosting configuration bugs.

Issue Fix
Fixes #2693 Late user descriptions drop the email address when the project doesn't collect private information, matching the event pipeline.
Fixes #2694 HTTPS redirection is registered outside Development. The old check read server addresses before Kestrel bound, so it was always off. The middleware does nothing when there's no HTTPS endpoint, and the images bind HTTP only.
Fixes #2695 Helm: default Elasticsearch and Redis hosts match the chart's service names; event-posts, cleanup-data and download-geoip mount the storage claim; storage class, access modes and size are values (default: cluster class); the migration CronJob is suspend: true. Hosted values keep managed-csi-premium.
Fixes #2697 smtps://host keeps port 465. The smtps scheme now always picks TLS: implicit on 465, STARTTLS otherwise.
Fixes #2707 OpenAPI docs say identity.name and scope global.

Tests: new tests for the user-description email and the SMTP ports. MailerTests, EventEndpointTests and OpenApiSnapshotTests pass. Ran helm lint and helm template; the chart hasn't been installed on a cluster.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T19:56:26.739619Z 6c7467e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 23% 22% 130 ❌
Exceptionless.Core 78% 70% 10990 ✔
Exceptionless.Insulation 51% 43% 370 ➖
Exceptionless.Web 86% 72% 9423 ✔
Summary 81% (28625 / 35497) 70% (14339 / 20502) 20913 ✔

}

Host = uri.Host;
Port = uri.IsDefaultPort ? 25 : uri.Port;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this still needed?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment