Skip to content

Count batch occurrences once and keep tags for events sharing a stack - #2732

Open
ejsmith wants to merge 5 commits into
mainfrom
fix/event-batch-stack-sharing
Open

ejsmith wants to merge 5 commits into
mainfrom
fix/event-batch-stack-sharing

Conversation

@ejsmith

@ejsmith ejsmith commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Fix two pipeline bugs when several events in one batch land on the same stack. Split out of #2716; the commits are Blake's.

Bugs

Path Before After
Signature match (common path) Events share one stack object, but 060_UpdateStatsAction adds the batch count once per event, so in-memory TotalOccurrences grows by count². That value drives the notification throttle (> 2) and webhook payloads. Counts are added once per stack.
Explicit StackId Each event gets its own cloned stack, and only the last one is kept, so tags from earlier events are never saved. Events with the same stack id share one stack object.

010_AssignToStackAction now registers every successful event by stack id, so events on the same stack always share one object. 060_UpdateStatsAction updates each shared stack once.

Now that #2716 has merged, 030_CheckForRegressionAction sets the shared stack's Regressed status once instead of on every context (Blake's bda7fec).

Testing

  • EventPipelineTests: 67 passed, 1 skipped. New integration tests cover shared and explicit stack references, tag accumulation, occurrence totals, and distinct ids with duplicate signatures.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T06:07:44.404083Z 2916c95 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ejsmith and others added 2 commits November 18, 2026 00:05
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 23% 22% 130 ❌
Exceptionless.Core 78% 70% 11204 ✔
Exceptionless.Insulation 51% 43% 370 ➖
Exceptionless.Web 87% 73% 10316 ✔
Summary 81% (29948 / 36860) 71% (15308 / 21576) 22020 ✔

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants