Repository navigation
fix(feeds): preserve fractional media rates and durations - #2382
Aschenbath wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
[Medium impact] The PR appears safe to merge.
|
Media RSS numeric attributes currently use
parseInt, sosamplingrate="44.1"becomes44andframerate="29.97"becomes29. The Media RSS specification includes a44.1kHz sampling-rate example.Parse bitrate, frame rate, sampling rate and duration as floating-point numbers. File sizes, channel counts and image dimensions retain integer parsing. Add RSS and Atom regressions for fractional values, zero values and omitted attributes.
Validation on Windows with Node 24.22.0:
npm test: 96 tests passed, plus ESLint, TypeScript and Biome checks. Biome reports two existing configuration notices.npm run buildandgit diff --checkpass.Prepared and validated with OpenAI Codex assistance.
Summary by CodeRabbit