Skip to content

fix: escape template interpolations and move release to trusted publishing (review bundle 8) #21

Open

Description

@Bccorb
  • L-OPS-1 Messaging HTML templates do not escape appName, token or URL, and the validators are loose. Not exploitable through the API's direct-send path; an admin who sets app_name can inject markup. Side effect: allow-listed custom-scheme magic link redirects never send. Where: packages/core/src/service.ts, validation.ts:10-14,25-35. Fix: HTML-escape interpolations, emit new URL(x).href, require exactly http: or https: where a web URL is meant, and decide how custom-scheme redirects are sent.
  • L-OPS-2 .github/workflows/release.yml:55-56 publishes with a long-lived NPM_TOKEN. Move to trusted publishing with provenance and delete the secret. Same change in seamless-auth-types and seamless-auth-oidc-provider.

Source

Internal security review of 2026-11-09 (bundle 8, L-OPS-1 and L-OPS-2), read at 5534f0e. Found by reading code; nothing was executed. Status: Reported.

Activity

  1. added this to the v0.24 milestone on Nov 10, 2026
  2. added
    v0.24Release v0.24: security release and stabilization
    P2Priority 2
    secureMost secure promise
    on Nov 10, 2026
  3. Bccorb commented on Nov 10, 2026

    @Bccorb
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Priority 2secureMost secure promisev0.24Release v0.24: security release and stabilization

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions