Repository navigation
Preserve requested filename for cached loader fallback - #387
Open
stareezy-1 wants to merge 1 commit into
Open
stareezy-1 wants to merge 1 commit into
stareezy-1 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromCachecurrently passes a filename resolved by the first loader intoFromFile. When a later loader uses a different namespace (for example an embeddedfs.FSafter a local filesystem loader), a path that works withFromFilefails withFromCache.Pass the original requested filename to
FromFileon a cache miss so each loader resolves it independently. Cache keys and invalidation behavior remain unchanged.Fixes #313.
The
fstestregression checks fallback rendering, cached reuse,CleanCache, and debug mode; it fails before the fix.go test -race ./...andgo vet ./...pass. Full golangci-lint reports 12 findings in unchanged upstream files;golangci-lint run --new-from-rev=origin/masterpasses with zero new findings.