Repository navigation
Conversation
Executing a template twice dropped another newline because TrimBlocks rewrote the shared tokens on every render.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrimBlocksandLStripBlocksrewrite the template tokens.Executedid that on every call, so a cached template lost another newline on the second render.The trim now runs once. The first render is still
a\nb\n\nc\n. The second render stays the same.Fixes #386.
Test plan
go test -count=1 -run TestIssue386 .failed before the change (second render "a\nb\nc\n", first render "a\nb\n\nc\n") and passes after itgo test -count=1 .passesgo test -race -count=1 -run TestIssue386 .passes