Skip to content

Issue while retrying uploads #388

Open

Description

@choicl

Hi everyone, I have an issue with retrying uploads. I've been uploading small files (less or equal 100KB), sizeUploaded() for them were the same as files size, but short-term disconnection happened and the code reached retry case case 'retry': this.flowObj.fire('fileRetry', this, chunk); break;
Files were already uploaded, however the retry was fired multiple times and then just failed.
Shouldn't the file size be checked while file upload retrying?

Activity

  1. AidasK commented on Jul 24, 2024

    @AidasK
    Member

    Hi! File size check is optional as this is not a stream upload. It's uploading in chunks and file for each chunk is created only if file upload succeeds. Also partial file upload is not possible since we are doing a chunk rename instead of a copy. And lastly we do check the size of each chunk as it's not cpu intensive. Answers are based on php implementation here https://github.com/flowjs/flow-php-server/blob/master/src/Flow/File.php#L79

  2. choicl commented on Jul 24, 2024

    @choicl
    Author

    @AidasK thank you for the answer! Now I'm just trying to understand, can it be somehow configured within flowjs npm package or it requires some custom handling from my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions