Repository navigation
feat(build): Stamp each build step's DONE line with when it ended (backport #634) - #635
Open
mergify[bot] wants to merge 1 commit into
Open
mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
BuildKit's plain output only gives a step's duration, and Press reads the output from Redis on its own schedule, so it can't tell when a step ended. The agent sees each line as Docker prints it, so it appends the UTC time to DONE lines for build metrics. The time goes after the duration so Press, which reads the duration as the second word, parses these lines as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit dc9ff16)
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildKit's plain progress output gives each step's duration (
#12 DONE 3.2s) but not when it happened. Press reads the build output from Redis on its own schedule, so it can't tell either. The agent sees each line the moment Docker prints it, so it now appends the UTC time toDONElines:This lets Press record when each build step ended, for build time metrics (frappe/press PR to follow).
Safe to deploy before or after Press: Press reads the duration as the second word of the line, so the extra time is ignored until Press starts reading it.
CACHEDand other lines are unchanged.🤖 Generated with Claude Code
This is an automatic backport of pull request #634 done by [Mergify](https://mergify.com).