Repository navigation
feat: add a Select template with editable options - #999
Open
SmrutiSawant wants to merge 13 commits into
Open
SmrutiSawant wants to merge 13 commits into
SmrutiSawant wants to merge 13 commits into
Conversation
Input, textarea and select fields now show Name and Required in Input Options, so you no longer have to set them in HTML Attributes. These settings read customAttributes first, where the form templates keep them, and keep both copies in sync when edited, since published pages let customAttributes win. Type is hidden on textareas and selects, and Placeholder on selects, where they do nothing. The Label template's input now has the id its label points at.
Contributor
 [Medium impact] The PR appears safe to merge. Reviews (4) · Last reviewed commit: "fix: only rename options of a select ins..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #999 +/- ##
===========================================
+ Coverage 76.07% 76.10% +0.03%
===========================================
Files 131 131
Lines 13405 13423 +18
===========================================
+ Hits 10198 10216 +18
Misses 3207 3207 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #997 . This PR includes its commits until that one merges.
What
Adds a Select (dropdown) to Form parts. It comes with a label and a few options to start with.
When you select the dropdown, you can set:
Demo
select.mp4